Eareamland wrote:Dark theme isn't working for me. It just gives me the regular rift theme when I turn it on but settings claims it's still dark theme. What is wrong?
https://dark.nationstates.net/
Try this for alternative.
Advertisement
by Harmonic Empire » Wed May 20, 2020 5:45 am
Eareamland wrote:Dark theme isn't working for me. It just gives me the regular rift theme when I turn it on but settings claims it's still dark theme. What is wrong?
by Northrop-Grumman » Thu Jun 04, 2020 2:55 pm
by Ever-Wandering Souls » Thu Jun 04, 2020 3:16 pm
Northrop-Grumman wrote:Updated!
2020-05-26
- Removed colored header on plain user-created tables.
- Inverted RSS icon on hover in Dossier.
- Darkened background of "How Election Works" panel on the WA Secretary-General election page.
- Fixed Z-day faction name to inherit background color.
- Fixed Z-day countdowns on News page to inherit background color.
- Rounded top corners of telegram filters table.
The Alicorns (Equestria) wrote:Let them stay, no need to badmouth them...From our view a bunch of nations just came in, seized the delegate position, and changed a few superficial things...we play NationStates differently...there's really no reason for us to be butthurt.
http://www.nationstates.net/page=rmb/postid=8944227
http://www.nationstates.net/page=rmb/postid=8951258
Reploid Productions wrote:Raiders are endlessly creative
by Northrop-Grumman » Thu Jun 04, 2020 5:32 pm
I just did a comparison between the old and new stylesheets and you're right. The cards tables was evidently something I overlooked when I made that change. I'm terribly sorry for that and will work on a fix.Ever-Wandering Souls wrote:Northrop-Grumman wrote:Updated!
2020-05-26
- Removed colored header on plain user-created tables.
- Inverted RSS icon on hover in Dossier.
- Darkened background of "How Election Works" panel on the WA Secretary-General election page.
- Fixed Z-day faction name to inherit background color.
- Fixed Z-day countdowns on News page to inherit background color.
- Rounded top corners of telegram filters table.
Hi,
No offense, but is this why cards tables suddenly look....blahhh?
One example, but applies to other cards-related tables at least too. That header is painfully bright.
by Ever-Wandering Souls » Thu Jun 04, 2020 6:37 pm
The Alicorns (Equestria) wrote:Let them stay, no need to badmouth them...From our view a bunch of nations just came in, seized the delegate position, and changed a few superficial things...we play NationStates differently...there's really no reason for us to be butthurt.
http://www.nationstates.net/page=rmb/postid=8944227
http://www.nationstates.net/page=rmb/postid=8951258
Reploid Productions wrote:Raiders are endlessly creative
by Northrop-Grumman » Fri Jun 05, 2020 3:51 am
There's a period of delay, so it could be a couple of days before they're applied. I submit the new stylesheets and then they're applied by Max, [violet], etc.Ever-Wandering Souls wrote:Hey, thanks for the prompt fix NG, my eyes are very grateful
Is this fix intended to be applied at time of posting or is there a period of delay?
by Northrop-Grumman » Sun Jun 07, 2020 7:53 am
by Ever-Wandering Souls » Sun Jun 07, 2020 9:27 am
Northrop-Grumman wrote:The update has been applied. If anyone has any issues, please let me know!
The Alicorns (Equestria) wrote:Let them stay, no need to badmouth them...From our view a bunch of nations just came in, seized the delegate position, and changed a few superficial things...we play NationStates differently...there's really no reason for us to be butthurt.
http://www.nationstates.net/page=rmb/postid=8944227
http://www.nationstates.net/page=rmb/postid=8951258
Reploid Productions wrote:Raiders are endlessly creative
by Northrop-Grumman » Tue Sep 29, 2020 6:59 am
by Khoronzon » Thu Dec 24, 2020 12:02 pm
The world is no longer as it once was, moulded beyond recognition by the hands of its coming masters. Humanity is faced with a simple choice: evolve, or die.
by Northrop-Grumman » Mon Dec 28, 2020 10:54 am
Do you have a specific webpage/article/dispatch where this is happening? I can see the difference in the pictures you've posted, but to get a better idea on what's going on, I'd need to be able see the style coding behind it.Khoronzon wrote:I made a thread a while back about dark theme changing the colour of images, and was suggested to direct my comments here, so here it is. TL;DR: The way dispatch images and banners get darkened makes it so that it's impossible to properly synchronise images with background colours, or flags with banners, across both light and dark themes, so it'd be helpful if the darkening effect was taken out or at least alleviated.
When I implemented the dark theme, one of the things I did was to maintain the rounded corners across the site, so that it would be consistent. The only area that didn't happen is with the page numbers, because they're so small and it just didn't look right. You're correct about the new code though; that's not something that I can implement. I can only take what's there and tweak the styling of it.Khoronzon wrote:There's also this other thread I made regarding [box]es and cross-theme compatibility, though I'm not sure if it's something you'd be able to do much about since my suggestion to address it involves introducing new code to NS itself - I may as well bring it up anyway in case there is anything that can be done or if you feel inclined to bring it up to the admins, since I feel like they might be a bit more likely to listen.
by Khoronzon » Mon Dec 28, 2020 1:05 pm
Northrop-Grumman wrote:Do you have a specific webpage/article/dispatch where this is happening? I can see the difference in the pictures you've posted, but to get a better idea on what's going on, I'd need to be able see the style coding behind it.
The world is no longer as it once was, moulded beyond recognition by the hands of its coming masters. Humanity is faced with a simple choice: evolve, or die.
by Bernie » Tue Dec 29, 2020 5:34 am
Northrop-Grumman wrote:Do you have a specific webpage/article/dispatch where this is happening? I can see the difference in the pictures you've posted, but to get a better idea on what's going on, I'd need to be able see the style coding behind it.Khoronzon wrote:I made a thread a while back about dark theme changing the colour of images, and was suggested to direct my comments here, so here it is. TL;DR: The way dispatch images and banners get darkened makes it so that it's impossible to properly synchronise images with background colours, or flags with banners, across both light and dark themes, so it'd be helpful if the darkening effect was taken out or at least alleviated.
by Northrop-Grumman » Sun Jan 10, 2021 9:49 am
Alright, I'm understanding the issue now. That particular dispatch is structured like this:Khoronzon wrote:Northrop-Grumman wrote:Do you have a specific webpage/article/dispatch where this is happening? I can see the difference in the pictures you've posted, but to get a better idea on what's going on, I'd need to be able see the style coding behind it.
I hadn't posted it yet at the time of writing the thread, but here.
That is an inconsistency brought about because a filter is being used on the banner but not on the flag. Either they both need the filter or none of them do.Bernie wrote:Northrop-Grumman wrote:Do you have a specific webpage/article/dispatch where this is happening? I can see the difference in the pictures you've posted, but to get a better idea on what's going on, I'd need to be able see the style coding behind it.
I think it is the same issue he is having, but look at my flag and banner in light theme, then look at them in dark theme. In light theme the red from banner and flag match. In dark theme the banner is a totally different color.
by Khoronzon » Fri Feb 12, 2021 6:10 pm
Northrop-Grumman wrote:If you compensate for the dark theme filtering being done in the second section, the third section won't look right in the light theme, since that filtering is removed.
Northrop-Grumman wrote:That is an inconsistency brought about because a filter is being used on the banner but not on the flag. Either they both need the filter or none of them do.
The world is no longer as it once was, moulded beyond recognition by the hands of its coming masters. Humanity is faced with a simple choice: evolve, or die.
by Northrop-Grumman » Sun Feb 21, 2021 8:36 am
I appreciate the reminder!Khoronzon wrote:Northrop-Grumman wrote:If you compensate for the dark theme filtering being done in the second section, the third section won't look right in the light theme, since that filtering is removed.Northrop-Grumman wrote:That is an inconsistency brought about because a filter is being used on the banner but not on the flag. Either they both need the filter or none of them do.
I didn't want to press the matter earlier but now that it's bit a bit over a month, I felt like I might ask - will there be anything done to address these? I understand if you have other things to do or if there might be technical issues I'm not aware of, just wanted to check in. And if I may suggest something for the latter issue - I think the filtering that's applied to banners in dark mode is a fair bit darker than the one being applied to factbook images, so if having that filter there is an important feature, maybe it could be lightened up a bit and then applied to both flags and banners. It could also just be removed from banners, which might be more convenient, but that depends on how much you value having it.
by Northrop-Grumman » Sat Feb 27, 2021 9:41 am
It'll most likely take a couple of days to apply, but I've put together the changes and have them submitted.Khoronzon wrote:Northrop-Grumman wrote:If you compensate for the dark theme filtering being done in the second section, the third section won't look right in the light theme, since that filtering is removed.Northrop-Grumman wrote:That is an inconsistency brought about because a filter is being used on the banner but not on the flag. Either they both need the filter or none of them do.
I didn't want to press the matter earlier but now that it's bit a bit over a month, I felt like I might ask - will there be anything done to address these? I understand if you have other things to do or if there might be technical issues I'm not aware of, just wanted to check in. And if I may suggest something for the latter issue - I think the filtering that's applied to banners in dark mode is a fair bit darker than the one being applied to factbook images, so if having that filter there is an important feature, maybe it could be lightened up a bit and then applied to both flags and banners. It could also just be removed from banners, which might be more convenient, but that depends on how much you value having it.
by Khoronzon » Sat Feb 27, 2021 10:08 am
The world is no longer as it once was, moulded beyond recognition by the hands of its coming masters. Humanity is faced with a simple choice: evolve, or die.
by Valentine Z » Sun Feb 28, 2021 2:09 am
♪ If you are reading my sig, I want you to have the best day ever ! You are worth it, do not let anyone get you down ! ♪
Glory to De Geweldige Sierlijke Katachtige Utopia en Zijne Autonome Machten ov Valentine Z !
(✿◠‿◠) ☆ \(^_^)/ ☆
♡ Issues Thread ♡ Photography Stuff ♡ Project: Save F7. ♡ Stats Analysis ♡
♡ The Sixty! ♡ Valentian Stories! ♡ Gwen's Adventures! ♡
• Never trouble trouble until trouble troubles you.
• World Map is a cat playing with Australia.
by Khoronzon » Sun Feb 28, 2021 10:11 am
The world is no longer as it once was, moulded beyond recognition by the hands of its coming masters. Humanity is faced with a simple choice: evolve, or die.
by CBG-Palisade » Sun Feb 28, 2021 10:35 am
by Northrop-Grumman » Sun Feb 28, 2021 3:16 pm
They weren't taken completely out. I just made them a bit more consistent and lightened them up quite a bit. Instead of 80% brightness, they're sitting at 90% now, which should be a happy medium that takes the edge off of bright whites and doesn't lose the details in darker images.Valentine Z wrote:So I noticed that the dark filters on the home page and the factbooks (I think... at least the home page is) are being taken out. I am quite liking the change and it makes my flag and banner so much brighter, thank you! ♥
It's not a bother! And this is something I noticed early this morning after the changes were applied. Long story short, this is my fault. I'm fairly certain that when [violet] was changing the table structures in that thread, she also ensured that the dark theme consistently worked for the changes she was making. I forgot to check for those changes when I submitted my updates, so they're not there. I'm hoping to get that fixed some time this week.Khoronzon wrote:Sorry for bothering you again, but there's been a new change to [table=plain] in dark mode that I think might've somehow been a direct result of this - somewhat recently, [violet]'s added some features to tables, including making it so that [table=plain] wouldn't highlight when you hover over it in dark theme, and now it does just that. For reference, here's the same factbook when I hover over it in light, dark, and Century dark themes. If this is the wrong thread to be asking this, I'll head over to [violet]'s thread in which she introduced the table changes, but otherwise, could you remove the hover effect that [table=plain] now has so that it's more consistent with the other themes?
Hah, well, good to know! I appreciate the feedback. Every time I think I've caught everything, there's something that's overlooked. I feel like I need to craft a checklist for any changes.Khoronzon wrote:On an unrelated note, and this is a bit more minor of an issue - the image filter in dispatches still seems to apply when previewing edits. Here's this dispatch as it appears normally and as a preview. It's fairly liveable for the time being since it doesn't affect how the dispatches actually appear to viewers, but it makes them a bit more of a pain to edit when I'm trying to match images with background colours, as now I have to publish the edit every time I want to see how it looks.
Hrmm...interesting! Did this just start happening today? If so, it might be related to the issue mentioned above, which will get fixed. If not, do let me know!CBG-Palisade wrote:Furthermore it appears that somehow the filter is being applied in reverse to some images in dark mode, now. Despite me confirming that this header image, for instance, is the exact same color code as the background it sits beneath, in this factbook and the factbooks following its theme I see a clear lightening of that header image. On light mode this issue is still present. Any help you could give us on this issue would be appreciated, thanks.
For context, opening the relevant file in an image manipulation tool shows me that both it and the background are #222222.
Edit: More testing has also revealed that the filter is still applied in preview windows, but not in the actual factbooks themselves.
Edit 2: Apparently this issue only appears in Firefox? Not sure why, but I don't see it in either Light or Dark on Google Chrome.
by Northrop-Grumman » Sat Mar 06, 2021 12:33 pm
by Homyland » Thu May 13, 2021 8:47 am
by Osheiga » Tue Mar 28, 2023 9:01 pm
Advertisement
Users browsing this forum: Countriopia, Khantin, New Makasta, Radicalania, Sulenia, Valentine Z
Advertisement