NATION

PASSWORD

NationStates Dark Theme (Rift)

Bug reports, general help, ideas for improvements, and questions about how things are meant to work.

Advertisement

Remove ads

User avatar
Harmonic Empire
Diplomat
 
Posts: 794
Founded: Mar 17, 2017
Corporate Police State

Postby Harmonic Empire » Wed May 20, 2020 5:45 am

Eareamland wrote:Dark theme isn't working for me. It just gives me the regular rift theme when I turn it on but settings claims it's still dark theme. What is wrong?


https://dark.nationstates.net/
Try this for alternative.
| ♛ | HARMONIKSA RIKKEN | UNTEMAR | ♛ |
FanT set in a world of ungodly overpowered beings
Ase's Book - Eros's Book - Map - IC Flag - Nygru's Axe
Intermarium Issues: [NAT] Caserine Ylva opens commission with a high prize for any composer who can write a new anthem for Untermar with Cannon and Rocket; "If Cannon can become a musical instrument, then Rocket can work too!" | [NAT] "Every problem can be solved with rockets and more rockets." Caserine Ylva Brynhildr says as she shows off new improved Firestorm Rocket Battery. | [INT] Massive brawl in Ygremir: picture taken from scene shows General Nygru making v-sign with her hand while smiling at MagiCam.
Please be sure to check Terra Britania's works! | Prisoners are treated fairly, fairly poor that is.

User avatar
Northrop-Grumman
Ambassador
 
Posts: 1619
Founded: Dec 28, 2003
Benevolent Dictatorship

Postby Northrop-Grumman » Thu Jun 04, 2020 2:55 pm

Updated!

2020-05-26
- Removed colored header on plain user-created tables.
- Inverted RSS icon on hover in Dossier.
- Darkened background of "How Election Works" panel on the WA Secretary-General election page.
- Fixed Z-day faction name to inherit background color.
- Fixed Z-day countdowns on News page to inherit background color.
- Rounded top corners of telegram filters table.

User avatar
Ever-Wandering Souls
Negotiator
 
Posts: 6545
Founded: Jan 01, 2014
Father Knows Best State

Postby Ever-Wandering Souls » Thu Jun 04, 2020 3:16 pm

Northrop-Grumman wrote:Updated!

2020-05-26
- Removed colored header on plain user-created tables.
- Inverted RSS icon on hover in Dossier.
- Darkened background of "How Election Works" panel on the WA Secretary-General election page.
- Fixed Z-day faction name to inherit background color.
- Fixed Z-day countdowns on News page to inherit background color.
- Rounded top corners of telegram filters table.


Hi,

No offense, but is this why cards tables suddenly look....blahhh?

Image

One example, but applies to other cards-related tables at least too. That header is painfully bright.
Last edited by Ever-Wandering Souls on Thu Jun 04, 2020 3:17 pm, edited 1 time in total.
Proud Raider; General of The Black Hawks, Ret.
TG me anytime; I'm always happy to talk about anything!

The Alicorns (Equestria) wrote:Let them stay, no need to badmouth them...From our view a bunch of nations just came in, seized the delegate position, and changed a few superficial things...we play NationStates differently...there's really no reason for us to be butthurt.
http://www.nationstates.net/page=rmb/postid=8944227
http://www.nationstates.net/page=rmb/postid=8951258

Misley wrote:
Hobbesistan wrote:Don't think I understand the question.
The color or what?..

Jesus, Hobbes, it's 2015. You can't just call someone "the color".

Reploid Productions wrote:Raiders are endlessly creative

How Do I Telegram API?

Omnis delenda est.

User avatar
Northrop-Grumman
Ambassador
 
Posts: 1619
Founded: Dec 28, 2003
Benevolent Dictatorship

Postby Northrop-Grumman » Thu Jun 04, 2020 5:32 pm

Ever-Wandering Souls wrote:
Northrop-Grumman wrote:Updated!

2020-05-26
- Removed colored header on plain user-created tables.
- Inverted RSS icon on hover in Dossier.
- Darkened background of "How Election Works" panel on the WA Secretary-General election page.
- Fixed Z-day faction name to inherit background color.
- Fixed Z-day countdowns on News page to inherit background color.
- Rounded top corners of telegram filters table.


Hi,

No offense, but is this why cards tables suddenly look....blahhh?

Image

One example, but applies to other cards-related tables at least too. That header is painfully bright.
I just did a comparison between the old and new stylesheets and you're right. The cards tables was evidently something I overlooked when I made that change. I'm terribly sorry for that and will work on a fix.

Edit: I figured out the issue and what I have works to correct it.
Last edited by Northrop-Grumman on Thu Jun 04, 2020 5:44 pm, edited 1 time in total.

User avatar
Ever-Wandering Souls
Negotiator
 
Posts: 6545
Founded: Jan 01, 2014
Father Knows Best State

Postby Ever-Wandering Souls » Thu Jun 04, 2020 6:37 pm

Hey, thanks for the prompt fix NG, my eyes are very grateful :)

Is this fix intended to be applied at time of posting or is there a period of delay?
Last edited by Ever-Wandering Souls on Thu Jun 04, 2020 6:39 pm, edited 1 time in total.
Proud Raider; General of The Black Hawks, Ret.
TG me anytime; I'm always happy to talk about anything!

The Alicorns (Equestria) wrote:Let them stay, no need to badmouth them...From our view a bunch of nations just came in, seized the delegate position, and changed a few superficial things...we play NationStates differently...there's really no reason for us to be butthurt.
http://www.nationstates.net/page=rmb/postid=8944227
http://www.nationstates.net/page=rmb/postid=8951258

Misley wrote:
Hobbesistan wrote:Don't think I understand the question.
The color or what?..

Jesus, Hobbes, it's 2015. You can't just call someone "the color".

Reploid Productions wrote:Raiders are endlessly creative

How Do I Telegram API?

Omnis delenda est.

User avatar
Northrop-Grumman
Ambassador
 
Posts: 1619
Founded: Dec 28, 2003
Benevolent Dictatorship

Postby Northrop-Grumman » Fri Jun 05, 2020 3:51 am

Ever-Wandering Souls wrote:Hey, thanks for the prompt fix NG, my eyes are very grateful :)

Is this fix intended to be applied at time of posting or is there a period of delay?
There's a period of delay, so it could be a couple of days before they're applied. I submit the new stylesheets and then they're applied by Max, [violet], etc.

User avatar
Northrop-Grumman
Ambassador
 
Posts: 1619
Founded: Dec 28, 2003
Benevolent Dictatorship

Postby Northrop-Grumman » Sun Jun 07, 2020 7:53 am

The update has been applied. If anyone has any issues, please let me know!

User avatar
Ever-Wandering Souls
Negotiator
 
Posts: 6545
Founded: Jan 01, 2014
Father Knows Best State

Postby Ever-Wandering Souls » Sun Jun 07, 2020 9:27 am

Northrop-Grumman wrote:The update has been applied. If anyone has any issues, please let me know!


Much better, thanks!
Proud Raider; General of The Black Hawks, Ret.
TG me anytime; I'm always happy to talk about anything!

The Alicorns (Equestria) wrote:Let them stay, no need to badmouth them...From our view a bunch of nations just came in, seized the delegate position, and changed a few superficial things...we play NationStates differently...there's really no reason for us to be butthurt.
http://www.nationstates.net/page=rmb/postid=8944227
http://www.nationstates.net/page=rmb/postid=8951258

Misley wrote:
Hobbesistan wrote:Don't think I understand the question.
The color or what?..

Jesus, Hobbes, it's 2015. You can't just call someone "the color".

Reploid Productions wrote:Raiders are endlessly creative

How Do I Telegram API?

Omnis delenda est.

User avatar
Northrop-Grumman
Ambassador
 
Posts: 1619
Founded: Dec 28, 2003
Benevolent Dictatorship

Postby Northrop-Grumman » Tue Sep 29, 2020 6:59 am

Updated!

2020-09-24
- Darkened background of faction name on N-day pages
- Darkened background on hover for N-day menu/view options

User avatar
Khoronzon
Spokesperson
 
Posts: 179
Founded: Jul 31, 2019
Psychotic Dictatorship

Postby Khoronzon » Thu Dec 24, 2020 12:02 pm

I made a thread a while back about dark theme changing the colour of images, and was suggested to direct my comments here, so here it is. TL;DR: The way dispatch images and banners get darkened makes it so that it's impossible to properly synchronise images with background colours, or flags with banners, across both light and dark themes, so it'd be helpful if the darkening effect was taken out or at least alleviated.

There's also this other thread I made regarding [box]es and cross-theme compatibility, though I'm not sure if it's something you'd be able to do much about since my suggestion to address it involves introducing new code to NS itself - I may as well bring it up anyway in case there is anything that can be done or if you feel inclined to bring it up to the admins, since I feel like they might be a bit more likely to listen.
Tʜ Dɪɪɴ Sʀʏ Kʜʀɴɴ
Leader
Figures
Culture
Regions
Military
World
The world is no longer as it once was, moulded beyond recognition by the hands of its coming masters. Humanity is faced with a simple choice: evolve, or die.

△▽△
Theocratic quasi-eusocial ethnostate of anthropophagic transhuman supremacists in the scarred wastelands of Siberia
Featuring human brain farming, serial killer escapism, and a soul-eating extrauniversal larva posing as a superintelligent cyborg emperor
With human civilisation falling into atrophy, the Supremacy bides its time to sweep it all away
▽△▽
Quirky compass meemays #1 & #2Q&A threadFlag creditThemeCHALICEwaveDoes Khoronzon represent my views?
the gang's all here
update: horrible thing inspired by kiu is still in progress, i'm just really slow at drawing


User avatar
Northrop-Grumman
Ambassador
 
Posts: 1619
Founded: Dec 28, 2003
Benevolent Dictatorship

Postby Northrop-Grumman » Mon Dec 28, 2020 10:54 am

Khoronzon wrote:I made a thread a while back about dark theme changing the colour of images, and was suggested to direct my comments here, so here it is. TL;DR: The way dispatch images and banners get darkened makes it so that it's impossible to properly synchronise images with background colours, or flags with banners, across both light and dark themes, so it'd be helpful if the darkening effect was taken out or at least alleviated.
Do you have a specific webpage/article/dispatch where this is happening? I can see the difference in the pictures you've posted, but to get a better idea on what's going on, I'd need to be able see the style coding behind it.

Khoronzon wrote:There's also this other thread I made regarding [box]es and cross-theme compatibility, though I'm not sure if it's something you'd be able to do much about since my suggestion to address it involves introducing new code to NS itself - I may as well bring it up anyway in case there is anything that can be done or if you feel inclined to bring it up to the admins, since I feel like they might be a bit more likely to listen.
When I implemented the dark theme, one of the things I did was to maintain the rounded corners across the site, so that it would be consistent. The only area that didn't happen is with the page numbers, because they're so small and it just didn't look right. You're correct about the new code though; that's not something that I can implement. I can only take what's there and tweak the styling of it.

User avatar
Khoronzon
Spokesperson
 
Posts: 179
Founded: Jul 31, 2019
Psychotic Dictatorship

Postby Khoronzon » Mon Dec 28, 2020 1:05 pm

Northrop-Grumman wrote:Do you have a specific webpage/article/dispatch where this is happening? I can see the difference in the pictures you've posted, but to get a better idea on what's going on, I'd need to be able see the style coding behind it.

I hadn't posted it yet at the time of writing the thread, but here.
Tʜ Dɪɪɴ Sʀʏ Kʜʀɴɴ
Leader
Figures
Culture
Regions
Military
World
The world is no longer as it once was, moulded beyond recognition by the hands of its coming masters. Humanity is faced with a simple choice: evolve, or die.

△▽△
Theocratic quasi-eusocial ethnostate of anthropophagic transhuman supremacists in the scarred wastelands of Siberia
Featuring human brain farming, serial killer escapism, and a soul-eating extrauniversal larva posing as a superintelligent cyborg emperor
With human civilisation falling into atrophy, the Supremacy bides its time to sweep it all away
▽△▽
Quirky compass meemays #1 & #2Q&A threadFlag creditThemeCHALICEwaveDoes Khoronzon represent my views?
the gang's all here
update: horrible thing inspired by kiu is still in progress, i'm just really slow at drawing


User avatar
Bernie
Lobbyist
 
Posts: 11
Founded: Jan 08, 2019
Democratic Socialists

Postby Bernie » Tue Dec 29, 2020 5:34 am

Northrop-Grumman wrote:
Khoronzon wrote:I made a thread a while back about dark theme changing the colour of images, and was suggested to direct my comments here, so here it is. TL;DR: The way dispatch images and banners get darkened makes it so that it's impossible to properly synchronise images with background colours, or flags with banners, across both light and dark themes, so it'd be helpful if the darkening effect was taken out or at least alleviated.
Do you have a specific webpage/article/dispatch where this is happening? I can see the difference in the pictures you've posted, but to get a better idea on what's going on, I'd need to be able see the style coding behind it.

I think it is the same issue he is having, but look at my flag and banner in light theme, then look at them in dark theme. In light theme the red from banner and flag match. In dark theme the banner is a totally different color.

User avatar
Northrop-Grumman
Ambassador
 
Posts: 1619
Founded: Dec 28, 2003
Benevolent Dictatorship

Postby Northrop-Grumman » Sun Jan 10, 2021 9:49 am

Khoronzon wrote:
Northrop-Grumman wrote:Do you have a specific webpage/article/dispatch where this is happening? I can see the difference in the pictures you've posted, but to get a better idea on what's going on, I'd need to be able see the style coding behind it.

I hadn't posted it yet at the time of writing the thread, but here.
Alright, I'm understanding the issue now. That particular dispatch is structured like this:
  • The first section uses a black background color using BBcode.
  • The second section uses a picture as a transition between the colors of the first and third sections, which is what's being affected by the filtering that the Dark theme uses.
  • The third section uses another background color (#dfb1ad in hex) using BBcode.

If you compensate for the dark theme filtering being done in the second section, the third section won't look right in the light theme, since that filtering is removed.

Bernie wrote:
Northrop-Grumman wrote:Do you have a specific webpage/article/dispatch where this is happening? I can see the difference in the pictures you've posted, but to get a better idea on what's going on, I'd need to be able see the style coding behind it.

I think it is the same issue he is having, but look at my flag and banner in light theme, then look at them in dark theme. In light theme the red from banner and flag match. In dark theme the banner is a totally different color.
That is an inconsistency brought about because a filter is being used on the banner but not on the flag. Either they both need the filter or none of them do.

User avatar
Khoronzon
Spokesperson
 
Posts: 179
Founded: Jul 31, 2019
Psychotic Dictatorship

Postby Khoronzon » Fri Feb 12, 2021 6:10 pm

Northrop-Grumman wrote:If you compensate for the dark theme filtering being done in the second section, the third section won't look right in the light theme, since that filtering is removed.

Northrop-Grumman wrote:That is an inconsistency brought about because a filter is being used on the banner but not on the flag. Either they both need the filter or none of them do.

I didn't want to press the matter earlier but now that it's bit a bit over a month, I felt like I might ask - will there be anything done to address these? I understand if you have other things to do or if there might be technical issues I'm not aware of, just wanted to check in. And if I may suggest something for the latter issue - I think the filtering that's applied to banners in dark mode is a fair bit darker than the one being applied to factbook images, so if having that filter there is an important feature, maybe it could be lightened up a bit and then applied to both flags and banners. It could also just be removed from banners, which might be more convenient, but that depends on how much you value having it.
Tʜ Dɪɪɴ Sʀʏ Kʜʀɴɴ
Leader
Figures
Culture
Regions
Military
World
The world is no longer as it once was, moulded beyond recognition by the hands of its coming masters. Humanity is faced with a simple choice: evolve, or die.

△▽△
Theocratic quasi-eusocial ethnostate of anthropophagic transhuman supremacists in the scarred wastelands of Siberia
Featuring human brain farming, serial killer escapism, and a soul-eating extrauniversal larva posing as a superintelligent cyborg emperor
With human civilisation falling into atrophy, the Supremacy bides its time to sweep it all away
▽△▽
Quirky compass meemays #1 & #2Q&A threadFlag creditThemeCHALICEwaveDoes Khoronzon represent my views?
the gang's all here
update: horrible thing inspired by kiu is still in progress, i'm just really slow at drawing


User avatar
Northrop-Grumman
Ambassador
 
Posts: 1619
Founded: Dec 28, 2003
Benevolent Dictatorship

Postby Northrop-Grumman » Sun Feb 21, 2021 8:36 am

Khoronzon wrote:
Northrop-Grumman wrote:If you compensate for the dark theme filtering being done in the second section, the third section won't look right in the light theme, since that filtering is removed.

Northrop-Grumman wrote:That is an inconsistency brought about because a filter is being used on the banner but not on the flag. Either they both need the filter or none of them do.

I didn't want to press the matter earlier but now that it's bit a bit over a month, I felt like I might ask - will there be anything done to address these? I understand if you have other things to do or if there might be technical issues I'm not aware of, just wanted to check in. And if I may suggest something for the latter issue - I think the filtering that's applied to banners in dark mode is a fair bit darker than the one being applied to factbook images, so if having that filter there is an important feature, maybe it could be lightened up a bit and then applied to both flags and banners. It could also just be removed from banners, which might be more convenient, but that depends on how much you value having it.
I appreciate the reminder!

My apologies for all the delays; non-NS life has rather taken hold of me for the past several weeks, so it's been difficult to find the time to sit down on focus on coding. I had let the two leaders/capitals lists languish for the same amount of time and only today finally got them updated. I'm planning on looking at both themes (certain changes in one are made in the other, like the picture filters) today and next weekend.

User avatar
Northrop-Grumman
Ambassador
 
Posts: 1619
Founded: Dec 28, 2003
Benevolent Dictatorship

Postby Northrop-Grumman » Sat Feb 27, 2021 9:41 am

Khoronzon wrote:
Northrop-Grumman wrote:If you compensate for the dark theme filtering being done in the second section, the third section won't look right in the light theme, since that filtering is removed.

Northrop-Grumman wrote:That is an inconsistency brought about because a filter is being used on the banner but not on the flag. Either they both need the filter or none of them do.

I didn't want to press the matter earlier but now that it's bit a bit over a month, I felt like I might ask - will there be anything done to address these? I understand if you have other things to do or if there might be technical issues I'm not aware of, just wanted to check in. And if I may suggest something for the latter issue - I think the filtering that's applied to banners in dark mode is a fair bit darker than the one being applied to factbook images, so if having that filter there is an important feature, maybe it could be lightened up a bit and then applied to both flags and banners. It could also just be removed from banners, which might be more convenient, but that depends on how much you value having it.
It'll most likely take a couple of days to apply, but I've put together the changes and have them submitted.

I've completely removed the brightness filtering on the dispatch/factbook pages only. After doing some digging around, I discovered that there wasn't even such a filter being applied to the Century Dark theme dispatches/factbooks. That, plus the fact that folks can be really creative with what they do with the dispatches, in comparison to the limited features on posts and telegrams, made it so that there really wasn't a need to have that filter.

Also, the various flags and banners had different brightness filters, so I fixed that. They're all the same value. The only images that are different (aside from the dispatch/factbook) are the ones on the Issues page.
Last edited by Northrop-Grumman on Sat Feb 27, 2021 9:42 am, edited 1 time in total.

User avatar
Khoronzon
Spokesperson
 
Posts: 179
Founded: Jul 31, 2019
Psychotic Dictatorship

Postby Khoronzon » Sat Feb 27, 2021 10:08 am

Thanks a bunch for the changes, looking forward to seeing them roll out.
Tʜ Dɪɪɴ Sʀʏ Kʜʀɴɴ
Leader
Figures
Culture
Regions
Military
World
The world is no longer as it once was, moulded beyond recognition by the hands of its coming masters. Humanity is faced with a simple choice: evolve, or die.

△▽△
Theocratic quasi-eusocial ethnostate of anthropophagic transhuman supremacists in the scarred wastelands of Siberia
Featuring human brain farming, serial killer escapism, and a soul-eating extrauniversal larva posing as a superintelligent cyborg emperor
With human civilisation falling into atrophy, the Supremacy bides its time to sweep it all away
▽△▽
Quirky compass meemays #1 & #2Q&A threadFlag creditThemeCHALICEwaveDoes Khoronzon represent my views?
the gang's all here
update: horrible thing inspired by kiu is still in progress, i'm just really slow at drawing


User avatar
Valentine Z
Powerbroker
 
Posts: 9836
Founded: Nov 08, 2015
Scandinavian Liberal Paradise

Postby Valentine Z » Sun Feb 28, 2021 2:09 am

So I noticed that the dark filters on the home page and the factbooks (I think... at least the home page is) are being taken out. I am quite liking the change and it makes my flag and banner so much brighter, thank you! ♥
Last edited by Valentine Z on Sun Feb 28, 2021 2:11 am, edited 1 time in total.
Photography Stuff. ♡ ^_^ ♡ For You
Published my first issue.


Val's Stuff.
Flag Bracket - 1st for Mk I! 2nd for Mk II!
Issues Thread 4th in Gen Sec

The Sixty! Opinions Deposit! Valentian Stories! Gwen's Adventures! Cat Anthem! Valentian News.
If you are reading my sig, I want you to have the best day ever ! You are worth it, do not let anyone get you down !
Glory to De Geweldige Sierlijke Katachtige Utopia en Zijne Autonome Machten ov Valentine Z !
Q & A Here! | Heights of NS! | F7 Etiquette

Clarissa mistaken for Smurf/Avatar: 14
Valentijn Misgendered: 57
Valentijn now a She!

• Never trouble trouble until trouble troubles you.
• As a wise man once said: 我等は砲兵 皇国の護り (We are Artillery Guardians of the Empire).
• World Map is a cat playing with Australia.

User avatar
Khoronzon
Spokesperson
 
Posts: 179
Founded: Jul 31, 2019
Psychotic Dictatorship

Postby Khoronzon » Sun Feb 28, 2021 10:11 am

Sorry for bothering you again, but there's been a new change to [table=plain] in dark mode that I think might've somehow been a direct result of this - somewhat recently, [violet]'s added some features to tables, including making it so that [table=plain] wouldn't highlight when you hover over it in dark theme, and now it does just that. For reference, here's the same factbook when I hover over it in light, dark, and Century dark themes. If this is the wrong thread to be asking this, I'll head over to [violet]'s thread in which she introduced the table changes, but otherwise, could you remove the hover effect that [table=plain] now has so that it's more consistent with the other themes?

On an unrelated note, and this is a bit more minor of an issue - the image filter in dispatches still seems to apply when previewing edits. Here's this dispatch as it appears normally and as a preview. It's fairly liveable for the time being since it doesn't affect how the dispatches actually appear to viewers, but it makes them a bit more of a pain to edit when I'm trying to match images with background colours, as now I have to publish the edit every time I want to see how it looks.
Last edited by Khoronzon on Sun Feb 28, 2021 10:42 am, edited 1 time in total.
Tʜ Dɪɪɴ Sʀʏ Kʜʀɴɴ
Leader
Figures
Culture
Regions
Military
World
The world is no longer as it once was, moulded beyond recognition by the hands of its coming masters. Humanity is faced with a simple choice: evolve, or die.

△▽△
Theocratic quasi-eusocial ethnostate of anthropophagic transhuman supremacists in the scarred wastelands of Siberia
Featuring human brain farming, serial killer escapism, and a soul-eating extrauniversal larva posing as a superintelligent cyborg emperor
With human civilisation falling into atrophy, the Supremacy bides its time to sweep it all away
▽△▽
Quirky compass meemays #1 & #2Q&A threadFlag creditThemeCHALICEwaveDoes Khoronzon represent my views?
the gang's all here
update: horrible thing inspired by kiu is still in progress, i'm just really slow at drawing


User avatar
CBG-Palisade
Bureaucrat
 
Posts: 46
Founded: Jan 29, 2021
Left-wing Utopia

Postby CBG-Palisade » Sun Feb 28, 2021 10:35 am

Furthermore it appears that somehow the filter is being applied in reverse to some images in dark mode, now. Despite me confirming that this header image, for instance, is the exact same color code as the background it sits beneath, in this factbook and the factbooks following its theme I see a clear lightening of that header image. On light mode this issue is still present. Any help you could give us on this issue would be appreciated, thanks.

For context, opening the relevant file in an image manipulation tool shows me that both it and the background are #222222.

Edit: More testing has also revealed that the filter is still applied in preview windows, but not in the actual factbooks themselves.

Edit 2: Apparently this issue only appears in Firefox? Not sure why, but I don't see it in either Light or Dark on Google Chrome.
Last edited by CBG-Palisade on Sun Feb 28, 2021 1:36 pm, edited 2 times in total.
 ◑ THE CONFEDERACY IS DEAD - LONG LIVE THE CONFEDERACY ◐ 

Say to me no more Apollo...SoonLine Go UpNeed to finish thisNew nation, who dis?
Sacha's done, let's go-
reach doomer music when?
vaspelia wrote: this nation is wip and raw as fuck, please don't look at it yet

don't mind me, just vibin to filk over here

User avatar
Northrop-Grumman
Ambassador
 
Posts: 1619
Founded: Dec 28, 2003
Benevolent Dictatorship

Postby Northrop-Grumman » Sun Feb 28, 2021 3:16 pm

Valentine Z wrote:So I noticed that the dark filters on the home page and the factbooks (I think... at least the home page is) are being taken out. I am quite liking the change and it makes my flag and banner so much brighter, thank you! ♥
They weren't taken completely out. I just made them a bit more consistent and lightened them up quite a bit. Instead of 80% brightness, they're sitting at 90% now, which should be a happy medium that takes the edge off of bright whites and doesn't lose the details in darker images.

Khoronzon wrote:Sorry for bothering you again, but there's been a new change to [table=plain] in dark mode that I think might've somehow been a direct result of this - somewhat recently, [violet]'s added some features to tables, including making it so that [table=plain] wouldn't highlight when you hover over it in dark theme, and now it does just that. For reference, here's the same factbook when I hover over it in light, dark, and Century dark themes. If this is the wrong thread to be asking this, I'll head over to [violet]'s thread in which she introduced the table changes, but otherwise, could you remove the hover effect that [table=plain] now has so that it's more consistent with the other themes?
It's not a bother! And this is something I noticed early this morning after the changes were applied. Long story short, this is my fault. I'm fairly certain that when [violet] was changing the table structures in that thread, she also ensured that the dark theme consistently worked for the changes she was making. I forgot to check for those changes when I submitted my updates, so they're not there. I'm hoping to get that fixed some time this week.

Khoronzon wrote:On an unrelated note, and this is a bit more minor of an issue - the image filter in dispatches still seems to apply when previewing edits. Here's this dispatch as it appears normally and as a preview. It's fairly liveable for the time being since it doesn't affect how the dispatches actually appear to viewers, but it makes them a bit more of a pain to edit when I'm trying to match images with background colours, as now I have to publish the edit every time I want to see how it looks.
Hah, well, good to know! I appreciate the feedback. Every time I think I've caught everything, there's something that's overlooked. I feel like I need to craft a checklist for any changes.

CBG-Palisade wrote:Furthermore it appears that somehow the filter is being applied in reverse to some images in dark mode, now. Despite me confirming that this header image, for instance, is the exact same color code as the background it sits beneath, in this factbook and the factbooks following its theme I see a clear lightening of that header image. On light mode this issue is still present. Any help you could give us on this issue would be appreciated, thanks.

For context, opening the relevant file in an image manipulation tool shows me that both it and the background are #222222.

Edit: More testing has also revealed that the filter is still applied in preview windows, but not in the actual factbooks themselves.

Edit 2: Apparently this issue only appears in Firefox? Not sure why, but I don't see it in either Light or Dark on Google Chrome.
Hrmm...interesting! Did this just start happening today? If so, it might be related to the issue mentioned above, which will get fixed. If not, do let me know!
Last edited by Northrop-Grumman on Sun Feb 28, 2021 3:17 pm, edited 1 time in total.

User avatar
Northrop-Grumman
Ambassador
 
Posts: 1619
Founded: Dec 28, 2003
Benevolent Dictatorship

Postby Northrop-Grumman » Sat Mar 06, 2021 12:33 pm

Alright, I've submitted the below revisions to the dark theme. They should be applied within the next couple of days.

2020-03-06
- Fixed issue where plain tables were being highlighted on hover (removed highlight)
- Fixed issue where regular tables had bright highlights on hover (darkened highlight)
- Removed brightness filters on dispatch preview images to be consistent with Century Dark theme
- Darkened dispatch preview background to match posted dispatch background
- Added more rounded corners to dispatch preview

This will take care of the issues with the plain tables and the images being filtered on the dispatch previews. Also, as noted above, I mirrored the background of the dispatch previews to the final posted result; since the preview had a much lighter background, that most definitely didn't help folks figure out how their text colors and such looked without having to post and then edit it again when it didn't look right. Now, they're both black.

On a related note, I've been really impressed with the various things folks can do with their factbooks/dispatches, especially with the tables. Khoronzon and CBG-Palisade, I used both of your factbooks as testing grounds for ensuring the tables worked correctly, so I got a pretty good look at the great work y'all do.
Last edited by Northrop-Grumman on Sat Mar 06, 2021 12:34 pm, edited 1 time in total.

Previous

Advertisement

Remove ads

Return to Technical

Who is online

Users browsing this forum: Jurgen Klopp

Advertisement

Remove ads